Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancelling selection (pressing escape) while gizmo editing making uncommitted changes. #71156

Conversation

EricEzaM
Copy link
Contributor

  • Pressing escape while gizmo editing will discard the changes made during that edit 'session'

Fixes #71113

godot.windows.editor.dev.x86_64_AtDzyiI9cl.mp4
godot.windows.editor.dev.x86_64_gtg5l5jz1X.mp4

… uncommitted changes.

* Pressing escape while gizmo editing will discard the changes made during that edit 'session'
@EricEzaM EricEzaM requested review from a team as code owners January 10, 2023 11:31
@EricEzaM EricEzaM added this to the 4.0 milestone Jan 10, 2023
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I guess we can merge after 4.0 just to be safe.

@akien-mga akien-mga modified the milestones: 4.0, 4.1 Feb 17, 2023
@akien-mga akien-mga merged commit c3c425c into godotengine:master Mar 7, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancelling node selection with Escape breaks shape editing undo
3 participants