Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling node selection with Escape breaks shape editing undo #71113

Closed
KoBeWi opened this issue Jan 9, 2023 · 1 comment · Fixed by #71156
Closed

Cancelling node selection with Escape breaks shape editing undo #71113

KoBeWi opened this issue Jan 9, 2023 · 1 comment · Fixed by #71156

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jan 9, 2023

Godot version

4.0 964fc6e

System information

Windows 10 x64

Issue description

Tested with CollisionShape nodes. When you start dragging a shape, but press Escape without releasing the mouse button, the node gets deselected and the new size gets applied. You can't undo this action:
godot windows editor dev x86_64_iWtSiN8yMa
In case of 2D shapes it's worse, because when you click the node afterwards, it will stick to cursor until you click again:
godot windows editor dev x86_64_NMzIledZwf

Steps to reproduce

  1. Add a CollisionShape (2D or 3D)
  2. Add any editable shape
  3. Drag shape's handle to change it size
  4. Without releasing mouse button, press Escape

Minimal reproduction project

N/A

@EricEzaM
Copy link
Contributor

I assume this is the desired behaviour?

  • Escape Pressed
  • Revert to previous value, no commit made to undo/redo.

Interestingly moving nodes in the editor does not work like this. Pressing escape while drag-moving a node does nothing.

godot.windows.editor.dev.x86_64_gtg5l5jz1X.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants