-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the uid field of the tscn/res file is lost when the external dependency is updated #70234
Conversation
…ndency is updated
Superseded by #72257 I believe. |
This issue is still not fixed in v4.0.rc.custom_build [0c27edf]. See: 0.mp4 |
Ah yes, the code duplication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only glanced at the changes, but it seems to be doing the same thing that every ResourceLoaderText method repeats.
I think it is better to update dependencies separately from updating version. So that, other tags except This code actually just updates the version number. I'm not sure whether other places need to be updated when the version is updated. |
I've definitely seen this kind of problem when working on a game jam with multiple folks, whose commits in Git would often lack the UID for some scenes for whatever reason, which my Godot editor would then add, creating needless Git noise. |
Thanks! |
Cherry-picked for 4.0.3. |
I think this is one of those cases that i also tried to fix #75103 |
Solve the problem that the title tag is missing the uid field in #69794.
Hope this helps for #62258.