Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false warning when renaming Joint2D's node #67713

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix false warning when renaming Joint2D's node #67713

merged 1 commit into from
Nov 15, 2022
+12 −2

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 21, 2022

Steps to reproduce the bug:

  • add any Joint2D
  • add some physics nodes
  • set the target nodes in your Joint2D
  • make sure Joint2D has no configuration warning
  • rename any of the linked nodes
  • the NodePath is updated in the inspector and points correctly to the renamed node, but a configuration warning is triggered

@KoBeWi KoBeWi added this to the 4.0 milestone Oct 21, 2022
@KoBeWi KoBeWi requested a review from a team as a code owner October 21, 2022 13:40
akien-mga
akien-mga approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but could use call_deferred() now.

@akien-mga akien-mga merged commit 08d5d3d into godotengine:master Nov 15, 2022
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the smoke_Joint2D_everyday branch November 15, 2022 16:32
@KoBeWi KoBeWi mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:physics topic:2d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@KoBeWi @akien-mga