Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Update resize settings #59861

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Android: Update resize settings #59861

merged 1 commit into from
Apr 4, 2022

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 4, 2022

Update resize settings

  • Unlock resizing for the Godot Editor
  • Add an option to specify whether a game is resizeable for the Godot template

@m4gr3d m4gr3d added bug platform:android cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:export labels Apr 4, 2022
@m4gr3d m4gr3d added this to the 4.0 milestone Apr 4, 2022
@m4gr3d m4gr3d requested a review from a team as a code owner April 4, 2022 07:29
@m4gr3d m4gr3d mentioned this pull request Apr 4, 2022
Closed
@m4gr3d
Update resize settings:
3f299e9 
- Unlock resizing for the Godot Editor
- Add an option to specify whether a game is resizeable for the Godot template
@akien-mga akien-mga changed the title Update resize settings Android: Update resize settings Apr 4, 2022
@akien-mga akien-mga merged commit 10d9e47 into godotengine:master Apr 4, 2022
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the enable_resizable_main branch April 4, 2022 09:23
@Calinou
Copy link
Member

Calinou commented Apr 4, 2022

Add an option to specify whether a game is resizeable for the Godot template

Similar to #48943, shouldn't this be set automatically based on the resizable project setting?

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 4, 2022

Add an option to specify whether a game is resizeable for the Godot template

Similar to #48943, shouldn't this be set automatically based on the resizable project setting?

Thanks for the reminder! I forgot about that settings, I'll send another PR to use that instead.

@m4gr3d m4gr3d mentioned this pull request Apr 4, 2022
Merged
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 4, 2022

@Calinou Cleaned it up in #59880!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:export
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@m4gr3d @akien-mga @Calinou