Make android:resizeableActivity to true and do some ground normal work. #59731
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and android .gitignore should update for less files changed |
qianxliu
commented
Mar 31, 2022
|
I updated the |
akien-mga
added
the
cherrypick:3.x
|
It already become cleaner |
m4gr3d
requested changes
Apr 4, 2022
| @@ -29,11 +29,12 @@ | |||
| android:name=".GodotProjectManager" | |||
| android:configChanges="orientation|keyboardHidden|screenSize|smallestScreenSize|density|keyboard|navigation|screenLayout|uiMode" | |||
| android:launchMode="singleTask" | |||
| android:resizeableActivity="false" | |||
| android:resizeableActivity="true" | |||
There was a problem hiding this comment.
Here and below, you can remove the android:resizeableActivity attribute. It defaults to true so there's no need to repeat it here.
m4gr3d
reviewed
Apr 4, 2022
|
|
||
| <activity | ||
| android:name=".GodotGame" | ||
| android:configChanges="orientation|keyboardHidden|screenSize|smallestScreenSize|density|keyboard|navigation|screenLayout|uiMode" | ||
| android:label="@string/godot_project_name_string" | ||
| android:process=":GodotGame" | ||
| android:launchMode="singleTask" | ||
| android:resizeableActivity="false" | ||
| android:resizeableActivity="true" |
There was a problem hiding this comment.
@akien-mga Any arguments against doing the same for the templates?
On device that supports it, it seems preferable to resize rather than cut part of the game, or show black.
We can also make it a selectable option for the template.
|
Superseded by #59861. |
akien-mga
added
archived
and removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just make android:resizeableActivity to true and do some ground normal work.