Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the maximum number of concurrent DNS queries from 32 to 256 #59445

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 23, 2022

master version of #59520.

This makes the following error message less likely to be printed when performing many concurrent HTTP requests:

Condition ' resolving == IP::RESOLVER_INVALID_ID ' is true. returned: ERR_BUG

This closes #25052. Please test in your own projects 🙂

@Calinou Calinou requested a review from a team as a code owner March 23, 2022 16:08
@Calinou Calinou added this to the 4.0 milestone Mar 23, 2022
@Calinou Calinou force-pushed the dns-increase-resolver-max-queries branch from 8198f6f to d0ba952 Compare March 23, 2022 16:08
@Calinou Calinou requested a review from a team as a code owner March 23, 2022 16:08
@akien-mga
Copy link
Member

Maybe the error can also be made more explicit?

@akien-mga akien-mga requested a review from a team March 23, 2022 16:40
This makes the following error message less likely to be printed
when performing many concurrent HTTP requests:

    Condition ' resolving == IP::RESOLVER_INVALID_ID ' is true. returned: ERR_BUG
@Calinou Calinou force-pushed the dns-increase-resolver-max-queries branch from d0ba952 to 7d8b344 Compare March 23, 2022 17:18
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay, I mean, I don't really see cases where doing that many concurrent requests is actually okay, but given this is bothering users I think we can spare the extra few kb of RAM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS Resolver Issue: Condition ' resolving == IP::RESOLVER_INVALID_ID ' is true. returned: ERR_BUG
3 participants