Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for reaching maximum number of concurrent DNS queries is not explicit. #60602

Closed
Tracked by #42719
Mickeon opened this issue Apr 29, 2022 · 1 comment · Fixed by #64472
Closed
Tracked by #42719

Comments

@Mickeon
Copy link
Contributor

Mickeon commented Apr 29, 2022

Godot version

3.x

System information

Windows 10

Issue description

After #59445 upped the maximum concurrent DNS queries at any given time, it is much less likely to reach the limit, but not impossible. And should it occur, the console outputs:

Condition ' resolving == IP::RESOLVER_INVALID_ID ' is true. returned: ERR_BUG

This error message can potentially be very confusing. misleading and, compared to most other error messages in Godot, it looks quite cryptic. If the users doesn't know where to look, it's bound to cause a few headaches
Ideally, it should tell the user exactly what happened (the query limit has been reached), and potentially instruct the user on how to fix it (tone down the requests, or increase the limit, the latter of which should probably not be encouraged)

Steps to reproduce

No need.

Minimal reproduction project

No response

@Mickeon Mickeon changed the title Error for reaching maximum number of concurrent DNS queries is not explicit. Error message for reaching maximum number of concurrent DNS queries is not explicit. Apr 29, 2022
@Calinou
Copy link
Member

Calinou commented Apr 29, 2022

#59445 added error messages, but the error is actually emitted elsewhere.

or increase the limit, the latter of which should probably not be encouraged)

The limit is hardcoded, so you need to recompile the editor and export templates from source to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants