-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Fix navigation merge errors on too small triangles #56879
[3.x] Fix navigation merge errors on too small triangles #56879
Conversation
1be0142
to
6c90165
Compare
While analyzing further I've found yet another problem - when calculating cell key (id) we're dividing With additional precision improvement, everything works as expected, but it's still not perfect. I'll sync regarding it with @AndreaCatania offline. |
6c90165
to
210a1c7
Compare
I had to change In practice (flat meshes or meshes with some gentle hills) this makes no difference while this way we're able to avoid potential problems. The grid alignment algorithm will have to be re-done anyway, but IMO this commit at least polishes what's already there. |
210a1c7
to
be88ad4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks nice! Great job, just a small comment on the function get_point_key
.
be88ad4
to
d131e11
Compare
- improved `detail/sample_max_error` default value - improved floating point precision handling in cell key calculations - improved `merge error` error message - exposed `cell_height` of `nav_map` to the `Navigation` - fixed cell key `y` calculation
d131e11
to
6c6e50b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!! Thanks 🍉
Thanks! |
Fixes #56786 and part of #57254
See #56786 (comment) for detailed explanation.
Please note this change may potentially have a severe impact on navigation, so it would be nice if someone else can test the lack of errors as well as Agents traversing navmesh.
Once this is accepted I'll open similar for
master
.@Duroxxigar @AndreaCatania