Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add root node when drag-and-dropping in 3D editor #55626

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Dec 4, 2021

3.x version of #55522.

This also uses correct capitalization scheme for 3D meshes that are drag-and-dropped, like in the 2D editor.

Note: The new root node will be called "Spatial2" instead of "Spatial". This is because of a node naming conflict that occurs while the tree is being created, but I don't know why. This does not occur when using the scene tree dock button to create a root node.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to merge after 3.5 is released, might be worth a rebase just to be sure it's still working.

This also uses correct capitalization scheme for 3D meshes that are
drag-and-dropped, like in the 2D editor.
@Calinou Calinou force-pushed the 3d-editor-drag-and-drop-auto-root-node-3.x branch from 1ed8853 to 90cf668 Compare July 4, 2022 23:49
@Calinou
Copy link
Member Author

Calinou commented Jul 4, 2022

Seems fine to merge after 3.5 is released, might be worth a rebase just to be sure it's still working.

Rebased and tested again, it works as expected.

@akien-mga akien-mga merged commit 74de571 into godotengine:3.x Aug 5, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 3.x, 3.5 Aug 5, 2022
@Calinou Calinou deleted the 3d-editor-drag-and-drop-auto-root-node-3.x branch August 6, 2022 05:05
@akien-mga akien-mga modified the milestones: 3.5, 3.6 Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants