Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant assignment of blur_pipeline #50891

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Removed redundant assignment of blur_pipeline #50891

merged 1 commit into from
Jul 26, 2021
+2 −1

Conversation

VitikaSoni
Copy link
Contributor

@VitikaSoni VitikaSoni commented Jul 26, 2021 •
edited by Chaosus
Loading

I am new,if I made any mistakes let me know :)

Bugsquad edit: Fix #50852.

@VitikaSoni VitikaSoni requested a review from a team as a code owner July 26, 2021 14:12
@Chaosus Chaosus changed the title Removed Redundant assignement of blur_pipeline #50852 Removed redundant assignment of blur_pipeline Jul 26, 2021
@Chaosus Chaosus added this to the 4.0 milestone Jul 26, 2021
@akien-mga
Copy link
Member

akien-mga commented Jul 26, 2021 •
edited
Loading

There are code style issues, you used spaces for indentation instead of tabs, and your else brace style does not follow the code style used in surrounding code and the whole codebase.

See Code style guidelines for details.

To fix the style issues, make sure to use git commit --amend and git push --force when updating the PR. See PR workflow for details.

@VitikaSoni
Copy link
Contributor Author

@akien-mga thankyou very much

Calinou
Calinou approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Congratulations for your first merged pull request 🎉

@Calinou Calinou merged commit e6a544c into godotengine:master Jul 26, 2021
@VitikaSoni
Copy link
Contributor Author

Thanks! Congratulations for your first merged pull request 🎉

Thanks for the support 😊

@VitikaSoni VitikaSoni deleted the 50852 branch July 27, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Redundant assignment of blur_pipeline
4 participants
@VitikaSoni @akien-mga @Calinou @Chaosus