Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant assignment of blur_pipeline #50852

Closed
qarmin opened this issue Jul 25, 2021 · 4 comments · Fixed by #50891
Closed

Redundant assignment of blur_pipeline #50852

qarmin opened this issue Jul 25, 2021 · 4 comments · Fixed by #50891

Comments

@qarmin
Copy link
Contributor

qarmin commented Jul 25, 2021

Godot version

4.0 2a8a59e

Issue description

blur_pipeline = SSAO_BLUR_PASS_WIDE;
}
blur_pipeline = SSAO_BLUR_PASS_SMART;

@akien-mga
Copy link
Member

This can simply be made an else.

@VitikaSoni
Copy link
Contributor

@akien-mga I am very new to contributing,do you mean someone needs to put line 1355 in an else statement?

@Calinou
Copy link
Member

Calinou commented Jul 26, 2021

@akien-mga I am very new to contributing,do you mean someone needs to put line 1355 in an else statement?

Yes, only that line should be within the else statement.

@VitikaSoni
Copy link
Contributor

@Calinou thanks :)

@Chaosus Chaosus changed the title Redundant assignement of blur_pipeline Redundant assignment of blur_pipeline Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants