Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casing of the "to" stop word in editor strings #50418

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Fix casing of the "to" stop word in editor strings #50418

merged 1 commit into from
Jul 13, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 13, 2021 •
edited
Loading

master version of #50419.

This also fixes a C# documentation example that had one of its strings incorrectly converted.

Regex used to find occurrences: [a-zA-Z] To (with a trailing space)

@Calinou Calinou requested review from a team as code owners July 13, 2021 13:26
@Calinou Calinou added this to the 4.0 milestone Jul 13, 2021
@Calinou Calinou mentioned this pull request Jul 13, 2021
Merged
@Calinou Calinou mentioned this pull request Jul 13, 2021
Merged
@Calinou
Fix casing of the "to" stop word in editor strings
a3fbd68 
This also fixes a C# documentation example that had one of its
strings incorrectly converted.
@Calinou Calinou requested a review from a team as a code owner July 13, 2021 13:29
@Calinou Calinou removed request for a team July 13, 2021 13:29
@akien-mga akien-mga merged commit a4af760 into godotengine:master Jul 13, 2021
@akien-mga
Copy link
Member

Thanks!

@AaronRecord
Copy link
Contributor

Should this be cherry-picked?

@Calinou
Copy link
Member Author

Calinou commented Jul 15, 2021

Should this be cherry-picked?

Done here: #50419

@AaronRecord
Copy link
Contributor

AaronRecord commented Jul 15, 2021 •
edited
Loading

Whoops, sorry I missed that, I got confused because you never corrected it in #50490.
Edit: You don't have to open a new PR to fix it, I'm making a PR that allows using alt + [1-5] to zoom out, I'll fix it there.
Edit 2: Haha too late, you're too fast.

@Calinou Calinou deleted the fix-to-stop-word-casing branch August 3, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug documentation enhancement topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @akien-mga @AaronRecord