Improve 2D editor zoom logic #48252

Calinou · 2021-04-27T22:56:42Z

master version of #50490.

Add 1-5 shortcuts to zoom between 100% and 1600% quickly (similar to GIMP).
When holding down Alt, go through integer zoom values if above 100% or fractional zoom values with integer denominators if below 100% (50%, ~33.3%, 25%, …).

This closes godotengine/godot-proposals#2658.

mathias17 · 2021-04-28T06:30:50Z

OK this is even better - simply pressing 1-9, without using Control, to alter zoom.

Two questions:

Will these 9 new shortcuts be added to the Shortcuts tab in Editor Settings?
Will these 9 new shortcuts work no matter which panel currently has focus?

Calinou · 2021-04-28T12:30:01Z

Will these 9 new shortcuts be added to the Shortcuts tab in Editor Settings?

Yes, this is already done 🙂

Will these 9 new shortcuts work no matter which panel currently has focus?

No, these only work if the 2D editor viewport is focused. Making them work even if the 2D editor viewport isn't focused might be possible in master, but it's almost guaranteed to open a can of worms with regards to shortcut conflicts when this is cherry-picked for 3.x.

groud · 2021-06-17T10:35:04Z

I am not really sold on the proposal. This is a lot of shortcuts for something that simply requires pressing Ctrl+'+' or Ctrl+'-' otherwise. And I'm not sure we need that amount of different values with one key each.

I think it would make more sense to make those 1-9 keys switch between scenes for example.

mathias17 · 2021-06-17T14:22:43Z

I am not really sold on the proposal. This is a lot of shortcuts for something that simply requires pressing Ctrl+'+' or Ctrl+'-' otherwise. And I'm not sure we need that amount of different values with one key each.

I think it would make more sense to make those 1-9 keys switch between scenes for example.

Interesting idea for number row keys 1 through 0 to be mapped to scene tabs. I think I would actually use that.
This type of shortcut functionality doesn't seem like the user would be able to modify it. I guess it would just be an arbitrary feature that users wouldn't be able to modify/turn off - which is fine.

If the consensus is for 1 - 0 to be mapped to scene tabs, I still suggest CTRL+[number] for specific zoom shortcuts.

And at the very least, as part of this proposal - ALT+SCROLLWHEEL will snap to integer zoom values. A big improvement, imo.

KoBeWi · 2021-07-08T11:02:51Z

I think it would make more sense to make those 1-9 keys switch between scenes for example.

The difference is that there's no way to jump to zoom values, while you have all scene tabs available at once. No reason to switch them with number if you can just click them.

That said, the "1" shortcut is the same as clicking zoom label, but personally I also use it to reset zoom 🤔

EDIT:
I know noticed that there is both "Reset Zoom" and "Zoom 100%". I think the former should be removed.

Calinou · 2021-07-08T17:51:39Z

I know noticed that there is both "Reset Zoom" and "Zoom 100%". I think the former should be removed.

We need both shortcuts until support for multiple editor shortcuts is implemented. (Otherwise, I have to hardcode one of them which isn't great.)

KoBeWi · 2021-07-08T17:59:46Z

I mean, if Reset Zoom and Zoom 100% is the same thing, we don't need both. I'd just remove Ctrl+0, as 1 is easier to use anyways.

Calinou · 2021-07-08T18:11:16Z

I'd just remove Ctrl+0, as 1 is easier to use anyways.

Most applications such as web browsers and code editors support Ctrl + 0 to reset the zoom. Removing that shortcut would break user expectations, but at the same time, removing 1 would also break user expectations for those coming from GIMP.

Edit: Rebased and tested again, it works successfully.

KoBeWi · 2021-07-08T22:22:44Z

Wow, that Alt-zoom is so nice to use.

I still think that having two functionally identical shortcuts is redundant. We could remove it for now and possibly re-add when the multi-event shortcuts are added.

Also, this is inspired by GIMP, but GIMP has actually 5 zoom shortcuts. 1 for 100%, 2 for 200%, 3 for 400%, 4 for 800 and 5 for 1600%. I tried the numerical zooms and, while this is handy, having 9 of them, with 100% increment isn't very useful (especially when Alt+wheel does exactly that). Maybe it could be changed to something closer to GIMP, i.e. less shortcuts and more exponential scale?

Calinou · 2021-07-08T22:26:52Z

Also, this is inspired by GIMP, but GIMP has actually 5 zoom shortcuts. 1 for 100%, 2 for 200%, 3 for 400%, 4 for 800 and 5 for 1600%. I tried the numerical zooms and, while this is handy, having 9 of them, with 100% increment isn't very useful (especially when Alt+wheel does exactly that). Maybe it could be changed to something closer to GIMP, i.e. less shortcuts and more exponential scale?

I thought about doing this at first, but I feel like zoom values above 900% aren't often useful in game development. (This is different when editing pixel art, for instance.)

KoBeWi · 2021-07-08T22:28:09Z

Then it could stop at 4 / 800%.

Calinou · 2021-07-08T22:30:33Z

Then it could stop at 4 / 800%.

Adding 5 / 1600% isn't a problem, it's just that being able to jump to any 100% increment quickly feels better overall. But at this point, I think anything is an upgrade over what we have currently.

KoBeWi · 2021-07-08T22:41:24Z

But Alt + wheel already gives 100% increment. Having 9 shortcuts for that would be only useful if you use keyboard only, which is unlikely in the editor. I use GIMP quite a bit and IMO its zoom shortcut scheme is enough.

Adding 5 / 1600% isn't a problem

I know. That's why we could just have 4 shortcuts. Or also 5, but with different increments, e.g. 100/200/400/600/800.

- Add 1-5 shortcuts to zoom between 100% and 1600% quickly (similar to GIMP). - When holding down Alt, go through integer zoom values if above 100% or fractional zoom values with integer denominators if below 100% (50%, ~33.3%, 25%, …).

Calinou · 2021-07-10T15:33:17Z

I changed the zoom shortcuts to use power-of-two integer factors between 100% and 1600%. It now works the same way it does in GIMP.

akien-mga · 2021-07-13T08:46:34Z

Thanks!

akien-mga · 2021-07-13T08:50:26Z

editor/plugins/canvas_item_editor_plugin.cpp

+	ED_SHORTCUT("canvas_item_editor/zoom_100_percent", TTR("Zoom To 100%"), KEY_1);
+	ED_SHORTCUT("canvas_item_editor/zoom_200_percent", TTR("Zoom To 200%"), KEY_2);
+	ED_SHORTCUT("canvas_item_editor/zoom_400_percent", TTR("Zoom To 400%"), KEY_3);
+	ED_SHORTCUT("canvas_item_editor/zoom_800_percent", TTR("Zoom To 800%"), KEY_4);
+	ED_SHORTCUT("canvas_item_editor/zoom_1600_percent", TTR("Zoom To 1600%"), KEY_5);


I think the correct capitalization would be "Zoom to 100%", etc.

https://titlecaseconverter.com/blog/is-to-capitalized/

Done: #50418

akien-mga · 2021-07-15T08:42:58Z

Could probably use a dedicated PR for 3.x, it's not trivial to cherry-pick.

Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:2d topic:editor usability labels Apr 27, 2021

Calinou added this to the 4.0 milestone Apr 27, 2021

akien-mga requested a review from a team June 17, 2021 10:28

Calinou force-pushed the improve-2d-editor-zoom branch from 8b5f3fa to 11c9882 Compare July 8, 2021 18:28

Calinou force-pushed the improve-2d-editor-zoom branch from 11c9882 to 8845240 Compare July 10, 2021 15:32

Improve 2D editor zoom logic

43f9699

- Add 1-5 shortcuts to zoom between 100% and 1600% quickly (similar to GIMP). - When holding down Alt, go through integer zoom values if above 100% or fractional zoom values with integer denominators if below 100% (50%, ~33.3%, 25%, …).

Calinou force-pushed the improve-2d-editor-zoom branch from 8845240 to 43f9699 Compare July 10, 2021 15:33

KoBeWi approved these changes Jul 10, 2021

View reviewed changes

akien-mga merged commit 51b0aed into godotengine:master Jul 13, 2021

akien-mga reviewed Jul 13, 2021

View reviewed changes

Calinou mentioned this pull request Jul 15, 2021

Improve 2D editor zoom logic (3.x) #50490

Merged

Calinou removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 15, 2021

Calinou deleted the improve-2d-editor-zoom branch July 15, 2021 15:18

AaronRecord mentioned this pull request Jul 15, 2021

Add shift + [1-5] keyboard shortcuts to zoom out #50498

Merged

Calinou mentioned this pull request Aug 8, 2021

Add modifer key for zoom steps in 2d editor #27622

Closed

larspet mentioned this pull request Aug 21, 2024

Add a zoom speed setting to the 2D editor #95906

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve 2D editor zoom logic #48252

Improve 2D editor zoom logic #48252

Calinou commented Apr 27, 2021 •

edited

Loading

mathias17 commented Apr 28, 2021

Calinou commented Apr 28, 2021 •

edited

Loading

groud commented Jun 17, 2021

mathias17 commented Jun 17, 2021 •

edited

Loading

KoBeWi commented Jul 8, 2021 •

edited

Loading

Calinou commented Jul 8, 2021 •

edited

Loading

KoBeWi commented Jul 8, 2021 •

edited

Loading

Calinou commented Jul 8, 2021 •

edited

Loading

KoBeWi commented Jul 8, 2021

Calinou commented Jul 8, 2021 •

edited

Loading

KoBeWi commented Jul 8, 2021 •

edited

Loading

Calinou commented Jul 8, 2021 •

edited

Loading

KoBeWi commented Jul 8, 2021

Calinou commented Jul 10, 2021 •

edited

Loading

akien-mga commented Jul 13, 2021

akien-mga Jul 13, 2021

Calinou Jul 13, 2021

akien-mga commented Jul 15, 2021

Improve 2D editor zoom logic #48252

Improve 2D editor zoom logic #48252

Conversation

Calinou commented Apr 27, 2021 • edited Loading

mathias17 commented Apr 28, 2021

Calinou commented Apr 28, 2021 • edited Loading

groud commented Jun 17, 2021

mathias17 commented Jun 17, 2021 • edited Loading

KoBeWi commented Jul 8, 2021 • edited Loading

Calinou commented Jul 8, 2021 • edited Loading

KoBeWi commented Jul 8, 2021 • edited Loading

Calinou commented Jul 8, 2021 • edited Loading

KoBeWi commented Jul 8, 2021

Calinou commented Jul 8, 2021 • edited Loading

KoBeWi commented Jul 8, 2021 • edited Loading

Calinou commented Jul 8, 2021 • edited Loading

KoBeWi commented Jul 8, 2021

Calinou commented Jul 10, 2021 • edited Loading

akien-mga commented Jul 13, 2021

akien-mga Jul 13, 2021

Choose a reason for hiding this comment

Calinou Jul 13, 2021

Choose a reason for hiding this comment

akien-mga commented Jul 15, 2021

Calinou commented Apr 27, 2021 •

edited

Loading

Calinou commented Apr 28, 2021 •

edited

Loading

mathias17 commented Jun 17, 2021 •

edited

Loading

KoBeWi commented Jul 8, 2021 •

edited

Loading

Calinou commented Jul 8, 2021 •

edited

Loading

KoBeWi commented Jul 8, 2021 •

edited

Loading

Calinou commented Jul 8, 2021 •

edited

Loading

Calinou commented Jul 8, 2021 •

edited

Loading

KoBeWi commented Jul 8, 2021 •

edited

Loading

Calinou commented Jul 8, 2021 •

edited

Loading

Calinou commented Jul 10, 2021 •

edited

Loading