Improve visibility rect/AABB generation usability in GPUParticles #50181
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
gpu-particles-improve-visibility-generation
branch
from
79ad079
to
d0ff5e5
Compare
akien-mga
reviewed
Jul 5, 2021
| // Add one second to the default generation lifetime, since the progress is updated every second. | ||
| generate_seconds->set_value(MAX(1.0, trunc(particles->get_lifetime()) + 1.0)); | ||
|
|
||
| if (generate_seconds->get_value() >= 11.0 + CMP_EPSILON) { |
There was a problem hiding this comment.
Is the epsilon really useful here?
There was a problem hiding this comment.
If the particle's lifetime is exactly 10 seconds (which means the automatically determined time generation is 11 seconds), I'd prefer the dialog not to show up.
If the lifetime is any greater than 10 seconds, the dialog should display so that you can reduce the generation time.
- Don't display the time dialog if the automatically calculated generation time is short enough. - Clarify the purpose of waiting in the progress dialog.
Calinou
force-pushed
the
gpu-particles-improve-visibility-generation
branch
from
d0ff5e5
to
1bd2142
Compare
akien-mga
approved these changes
Aug 16, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterversion of #50180