Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Improve visibility rect/AABB generation usability in Particles #50180

Merged
merged 1 commit into from
Aug 23, 2022
Merged

[3.x] Improve visibility rect/AABB generation usability in Particles #50180

merged 1 commit into from
Aug 23, 2022
+17 −12

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 5, 2021 •
edited
Loading

3.x version of #50181.

  • Don't display the time dialog if the automatically calculated generation time is short enough.
  • Clarify the purpose of waiting in the progress dialog.

@Calinou Calinou requested a review from a team as a code owner July 5, 2021 13:28
@Calinou Calinou mentioned this pull request Jul 5, 2021
Merged
@Calinou Calinou added this to the 3.4 milestone Jul 5, 2021
@Calinou Calinou force-pushed the gpu-particles-improve-visibility-generation-3.x branch 2 times, most recently from 54c7e86 to 9b71446 Compare July 5, 2021 13:30
@Calinou Calinou modified the milestones: 3.4, 3.5 Nov 3, 2021
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 3, 2022
@Calinou
Copy link
Member Author

Calinou commented Aug 23, 2022

@akien-mga I think this could be merged for 3.6, now that the master PR has been merged for a bit.

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Aug 23, 2022
@akien-mga
Copy link
Member

It might use a rebase, last one was 14 months ago.

@Calinou
Improve visibility rect/AABB generation usability in Particles
cf002d4 
- Don't display the time dialog if the automatically calculated
  generation time is short enough.
- Clarify the purpose of waiting in the progress dialog.
@Calinou Calinou force-pushed the gpu-particles-improve-visibility-generation-3.x branch from 9b71446 to cf002d4 Compare August 23, 2022 12:45
@Calinou
Copy link
Member Author

Calinou commented Aug 23, 2022

Rebased and tested again, it works as expected.

@akien-mga akien-mga merged commit ac9bdab into godotengine:3.x Aug 23, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the gpu-particles-improve-visibility-generation-3.x branch August 23, 2022 19:52
@akien-mga akien-mga changed the title Improve visibility rect/AABB generation usability in Particles (3.x) [3.x] Improve visibility rect/AABB generation usability in Particles Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:particles usability
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @akien-mga @mhilbrunner