-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rotation ability to material editor preview. #49466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, I'll let @JFonS or @aaronfranke confirm feature-wise.
ea78014
to
0297b67
Compare
c0767d5
to
2b39440
Compare
3a97613
to
00064f5
Compare
The feature looks good. I think this needs a rebase and some code clean-up as @aaronfranke mentioned. |
I still coudn't figure out how to implement code clean-ups as @aaronfranke mentioned. This PR is still good as it is, since it's the same way mesh editor's preview code implements. godot/editor/plugins/mesh_editor_plugin.cpp Lines 69 to 74 in cca072a
|
Can I ask for a rebase? Want to review it again for godot 4 beta |
de918c1
to
609512c
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about my comment of "Just do it like this" earlier, I just checked and actually the rotation order is different for this code, so trying to do it that way won't work as expected.
609512c
to
d4ee903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test does what I expected.
Thanks! |
Cherry-picked for 3.6. |
Mesh editor(Inspector while selecting MeshInstance3D) already had the ability to rotate the preview of currently edited mesh.
That feature is added to material editor.Just a copy paste from mesh_editor class.
Normal Preview:
normal-preview.mp4
Shader Preview:
shader-preview.mp4
Useful especially while shader editor is zoomed. If more primitives are added along with the built in sphere and cube then, it low key would act like that scrapped dedicated shader editor PR.