Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Option to automatically generate icons and launch screens #49464

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 9, 2021

3.x cherry-pick of #34140.

Note that generate_missing is still disabled by default, like in its master counterpart. I'm not sure whether we should enable it by default. cc @bruvzg

@akien-mga akien-mga merged commit 0ff487e into godotengine:3.x Jun 10, 2021
@akien-mga
Copy link
Member

Thanks!

@vini-guerrero
Copy link

vini-guerrero commented Jun 11, 2021

Hello!
I'm testing it with this PR's Github actions build...

Test Environment:
MacBook Pro 13 - 2018 Big Sur Version 11.4
Xcode 12.4 - Build version 12D4e

Is the idea of the feature to generate only-blank placeholder images or scale down from a certain input image?
If so, is there an expected min-size image to be used as an input for auto generation?

XCode Proj was generated with blank images

image

Then I tried to build it, but XCode got a parse error to open the project files. ( Possibly unrelated to the icons, but to my custom export templates )

image

Also, I've only marked Required Icons in Editor

image

Attached test project here.
godot-game-template.zip

@Calinou Calinou deleted the ios-export-generate-missing-icons-3.x branch August 3, 2021 15:59
@alexzheng
Copy link

I wonder why there are still required icons need to set.
Generate missing icons won't generate all these icons for iOS project?
It would be much straightforward to just set a 1024 X 1024 icon, and generate all other size.

@Calinou
Copy link
Member Author

Calinou commented Oct 27, 2021

I wonder why there are still required icons need to set. Generate missing icons won't generate all these icons for iOS project? It would be much straightforward to just set a 1024 X 1024 icon, and generate all other size.

See discussion in #54010.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants