Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Option to automatically generate icons and launch screens #34140

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 6, 2019

  • Adds export options to automatically generate missing iOS icons and launch screens from the project icon and boot splash.
  • Adds validity and image size checks for user specified custom icons and launch screens (Xcode project build will fail if image sizes aren't correct).

…nch screens from the project icon and boot splash.
@samgreen
Copy link
Contributor

I've always wondered why Godot requires the launch images. Xcode will happily create one for us if one is not supplied, which makes the image generation work around seem a bit heavy handed.

Additionally since iOS 10 (the earliest iOS version Godot currently supports) we can simply provide a LaunchScreen.xib or LaunchScreen.storyboard file to allow Xcode to inflate that interface on run and then both the launch images and app icons would become unneccessary.

@akien-mga akien-mga merged commit a832776 into godotengine:master Feb 10, 2020
@akien-mga
Copy link
Member

Thanks!

@Calinou
Copy link
Member

Calinou commented Jun 9, 2021

It seems this pull request was never backported to the 3.x branch (despite this PR being merged one day before the master-3.x announcement).
Edit: Cherry-picked here: #49464

Also, why is generate_missing disabled by default? I'd expect it to be enabled by default to make the iOS export work better out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants