Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix multiple issues with CSGPolygon #49314

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

madmiraal
Copy link
Contributor

3.x version of #49313.

Note: Although I've marked this as breaks compat, because it changes the way the shapes are created by fixing the way MODE_PATH ROTATION_PATH modes affect extrusion rotations, changes the UV material mappings, reverses the way MODE_PATH normals are defined (i.e. no longer requires them to be inverted see comment), and restricts the valid values for MODE_PATH's path_interval, I still think the quality of the fixes make it viable for 3.4, but the changes would need to be mentioned in the release notes.

@sairam4123
Copy link

For my game, I need to have path set to 0.25 for csg mesh to work, but in this case I guess it wouldn't work.

@madmiraal
Copy link
Contributor Author

Updated to fix bug identified by @stebulba here, and increased the granularity of path_interval in the editor to 0.05 to allow values like 0.25.

@madmiraal
Copy link
Contributor Author

Updated with suggested changes to the documentation included in #49313.

@akien-mga akien-mga merged commit bf383a3 into godotengine:3.x Aug 12, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants