Fixes normals of the generated geometry from CSGPolygon3D (follow along Path3D) #48412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GPolygon3D is set to mode Path and followed along a Path3D. Fixes godotengine#48408
|
Let me know if this is not how the issue needs to be addressed. I just reversed the order of vertices to flip the face normals. |
Calinou
added
bug
cherrypick:3.3
cherrypick:3.x
|
cc @madmiraal |
|
Often noticed that you had to flip the faces (which is an option in CSG) or in certain modes it would end up inside out. If this fixes that issue we need to be aware that this is a breaking change where lots of people will need to uncheck that option. |
This was referenced Jun 4, 2021
akien-mga
removed
cherrypick:3.x
|
Superseded by #49314. Thanks for the contribution nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed normals by inverting how the faces were getting created when CSGPolygon3D is set to mode Path and followed along a Path3D. Fixes #48408
The order of vertices have been reversed for the creation of faces. Fixed the face normal at the ends of the path also (reversed the vertices order).