Dynamic BVH broadphase in 2D & 3D Godot Physics #48629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port lawnjelly's dynamic BVH implementation from 3.x to be used in both 2D and 3D broadphases. Removed alternative broadphase implementations which are not meant to be used anymore since they are much slower. Includes changes in Rect2, Vector2, Vector3 that help with the template implementation of the dynamic BVH by uniformizing the interface between 2D and 3D math. Co-authored-by: lawnjelly <[email protected]>
pouleyKetchoupp
force-pushed
the
dynamic-bvh-broadphase-4.0
branch
from
8b5ec60
to
3877ed7
Compare
|
Preliminary look through it looks fine and quite straightforward (I'm assuming most of the BVH is the same so I'm just looking in detail at the interface with the existing 2d physics code). 👍 |
lawnjelly
approved these changes
May 11, 2021
|
Thanks! |
aaronfranke
reviewed
May 29, 2021
|
|
||
| _FORCE_INLINE_ int max_axis() const { | ||
| return x < y ? 1 : 0; | ||
| } |
There was a problem hiding this comment.
Note: This conflicted with #34005 (which I already rebased).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port @lawnjelly's dynamic BVH implementation from 3.x to be used in both 2D and 3D broadphases.
Remove alternative broadphase implementations which are not meant to be used anymore since they are much slower.
Includes changes in
Rect2,Vector2,Vector3that help with the template implementation of the dynamic BVH by uniformizing the interface between 2D and 3D math (from PR #48314).Dynamic BVH implementation originally made by @lawnjelly in PR #44901.
This PR only includes the changes in physics, the dynamic BVH is still not used in render.