-
-
Notifications
You must be signed in to change notification settings - Fork 20.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose max_axis_index
and max_axis_index
for Vector2(i)
#34005
Conversation
2fdbb0c
to
3d01712
Compare
5df7338
to
2b18e80
Compare
max_axis
and min_axis
for Vector2(i)
55dd94c
to
ae36a1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is not working as the added enums don't appear in the docs and are not documented as return types.
@akien-mga I'm not sure if that's possible to do with the current code for Variant types bound in |
1222c21
to
7ce60dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed in PR meeting: fine to expose, but we should see about better naming for this both here and for Vector3i
Reduz suggestion:
get_min_axis_index and get_max_axis_index
max_axis
and min_axis
for Vector2(i)max_axis_index
and max_axis_index
for Vector2(i)
Some cleanup with Vector3(i)'s methods so that it is consistent with Vector2, for example it returns enums internally (GDScript still gets ints).
Done, but I used the names |
Thanks! |
EDIT 3: This also renames them to have
_index
at the end as per @reduz's suggestion.Also some cleanup with core's Vector3 methods so that it is consistent, for example it returns enums internally (GDScript still gets ints).
EDIT: Also now fixes #34190.
EDIT 2:
max_axis
andmin_axis
were added to Vector2(i) internally with #48629, but this PR exposes them and uses the enum as the type.