Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative contrast values in the editor theme settings (3.x) #48540

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 7, 2021

3.x version of #48534. This PR does not include the default contrast value change, as the editor theme hasn't changed.

When using a negative contrast value, the base color will be lightened to create the derivative colors instead of being darkened.

This can lead to better-looking themes, especially for light themes.

When using a negative contrast value, the base color will be lightened
to create the derivative colors instead of being darkened.

This can lead to better-looking themes, especially for light themes.
@Calinou Calinou added this to the 3.4 milestone May 7, 2021
@Calinou Calinou changed the title Allow negative contrast values in the editor theme settings (3.X) Allow negative contrast values in the editor theme settings (3.x) May 7, 2021
@akien-mga akien-mga merged commit c8c8bce into godotengine:3.x May 9, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.1.

@Calinou Calinou deleted the editor-theme-allow-negative-contrast-3.x branch August 3, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants