Allow negative contrast values in the editor theme settings #48534
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a negative contrast value, the base color will be lightened to create the derivative colors instead of being darkened. This can lead to better-looking themes, especially for light themes.
|
PS: It would be interesting to see whether we should change the Light theme preset to use a negative contrast. Any opinions? |
akien-mga
approved these changes
May 9, 2021
|
Thanks!
Might be worth a try, but needs feedback from Light theme users (I tend to stick with the default so Dark theme). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterversion of #48540.When using a negative contrast value, the base color will be lightened to create the derivative colors instead of being darkened.
This can lead to better-looking themes, especially for light themes.
I also fixed the default theme contrast value not matching the new default.
See #48477 (comment).
Preview
Light theme
Custom theme based on Light theme with base color set to
#dddand contrast to-0.08