Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skeleton3D inspector Bone Transforms #47531

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

fire
Copy link
Member

@fire fire commented Mar 31, 2021

Fixes: #47430

@smix8 Can you confirm?

@fire fire requested a review from a team as a code owner March 31, 2021 16:19
@Calinou Calinou added this to the 4.0 milestone Mar 31, 2021
@smix8
Copy link
Contributor

smix8 commented Mar 31, 2021

As mentioned in the issue this would fix (in my test) the problem for inspector transforms not updating with changing bone selection.

After merging this there would be still the leftover issue with the animationplayer interference with the inspector update but maybe this should be split.

@fire fire added the confirmed label Mar 31, 2021
@fire fire requested a review from akien-mga April 2, 2021 17:04
@smix8
Copy link
Contributor

smix8 commented Apr 11, 2021

@akien-mga
can we merge this little fix?

@akien-mga akien-mga merged commit 4a1f2dc into godotengine:master Apr 11, 2021
@akien-mga
Copy link
Member

Thanks!

@fire fire deleted the update-skeleton-display branch August 26, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton3D inspector fails to display/update Bone Rest Transforms without AnimationPlayer
4 participants