Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 2D navigation consider scale #47133

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

groud
Copy link
Member

@groud groud commented Mar 18, 2021

Discovered while working on TileMap navigation. This make it so scaled NavigationRegion2D works correctly, as scale was ignored before.

@groud groud added this to the 4.0 milestone Mar 18, 2021
@groud groud requested a review from a team as a code owner March 18, 2021 14:03
@groud groud changed the title Make 2D navigation consider scale Draft: Make 2D navigation consider scale Mar 18, 2021
@groud groud marked this pull request as draft March 18, 2021 14:06
@groud
Copy link
Member Author

groud commented Mar 18, 2021

Don't merge yet, seems like there's still a bug remaining.

@groud groud marked this pull request as ready for review March 18, 2021 14:18
@groud
Copy link
Member Author

groud commented Mar 18, 2021

Alright, the bug seems fixed, seems like rotation was broken too (rotating the wrong direction, I'm not sure why).

@groud groud changed the title Draft: Make 2D navigation consider scale Make 2D navigation consider scale Mar 18, 2021
@akien-mga akien-mga merged commit 2fd445c into godotengine:master Mar 18, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants