Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document known bugs in BakedLightmap #38984

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 23, 2020

See #30929.

I doubt we'll be able to backport BakedLightmap fixes before 3.2.2's release, so it makes sense to warn people about it.

@akien-mga
Copy link
Member

I don't think that a non-discardable configuration warning is the right place for this. Let users use it if they have a use case for it.

At most I'd mention known issues in the documentation, not as a configuration warning.

@Calinou Calinou changed the title Add a configuration warning to BakedLightmap to warn about known issues Document known bugs in BakedLightmap May 24, 2020
@Calinou Calinou force-pushed the bakedlightmap-configuration-warning branch from 5e327f2 to 5fb5fb1 Compare May 24, 2020 19:29
@Calinou Calinou requested a review from a team as a code owner May 24, 2020 19:29
@Calinou
Copy link
Member Author

Calinou commented May 24, 2020

@akien-mga I changed it to a simple note in the BakedLightmap class reference.

@akien-mga akien-mga merged commit 11d6c0f into godotengine:3.2 May 25, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants