Fix joypad motion sensors example for C##116241
Merged
Repiteo merged 0 commit intogodotengine:masterfrom Feb 17, 2026
Merged
Conversation
raulsntos
reviewed
Feb 13, 2026
Member
raulsntos
left a comment
raulsntos
left a comment
There was a problem hiding this comment.
Thanks for improving the C# documentation. I missed reviewing this on the original PR, so I also reviewed some of the unchanged code.
AThousandShips
added
enhancement
bug
documentation
and removed
topic:dotnet
documentation
enhancement
labels
Nintorch
force-pushed
the
joy-motion-sensors-cs-docs-fix
branch
from
acb1fc7 to
3eba9af
Compare
Contributor
Author
|
Thank you for your review, raulsntos! I included your suggested changes into the code! :) |
Nintorch
force-pushed
the
joy-motion-sensors-cs-docs-fix
branch
from
3eba9af to
7e2a4f0
Compare
2 tasks
Contributor
|
Thanks! |
Member
|
For the record, GitHub seems bugged out on this merge batch and the PR view shows "0 commits", but the commit which was merged is indeed present in the master branch: 7e2a4f0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was browsing the latest documentation page for
Inputclass I noticed that theobjectvariable for the joypad motion sensors example in Input.start_joy_motion_sensors_calibration() method was highlighted, then I remembered thatobjectis a keyword/builtin type in C#, so it should not be used as a variable name. Oops :DAnd signal connection code in the examples in https://docs.godotengine.org/en/latest/classes/class_object.html used
(Class).SignalName.(Signal name)syntax, so I decided to use it here too.