Add joypad motion sensors tutorial#11692
Conversation
|
Thank you for your review, AThousandShips! I will be able to fix the text in the PR soon! |
0d68400 to
8f5a6f0
Compare
|
Might be a bit before this gets merged since it's for 4.7 |
0039ac9 to
89eb679
Compare
|
Thank you for your review, Calinou! I applied your suggestions! :) |
Meorge
left a comment
There was a problem hiding this comment.
I've included some comments/suggestions I have for improving the flow and wording.
This might be something to take a closer look at later after suggestions have been evaluated, but I felt like the accelerometer section spent longer on background information than the gyroscope section did. It'd probably make sense to restructure them a bit so that they are more consistent with their balance of "theory" (discussing what the sensor is, how it works, etc) and "practice" (examples, code snippets, etc).
f3a3525 to
2169a66
Compare
|
Thank you for your review, Meorge! I included your suggestions into the code! :) By the way, here's the website that I used for gyroscope usage examples: https://www.pcgamingwiki.com/wiki/List_of_games_that_support_tracked_motion_controllers_in_non-VR_gameplay#DualShock_4 |
2169a66 to
cad3aaf
Compare
Meorge
left a comment
There was a problem hiding this comment.
Added a few more little tweaks/suggestions 🙂
In a few spots I removed instances of things like "we" for succinctness; I don't recall off-hand what the official Godot manual style says about those. If it is indeed supposed to avoid that sort of phrasing, there are a few other spots in here that can be changed.
cad3aaf to
0220b24
Compare
| - Movement left and right are reported as **+X** and **-X**. | ||
| - Movement down and up are reported as **+Y** and **-Y**. | ||
| - Movement away from and towards the user are reported as **+Z** and **-Z**. |
There was a problem hiding this comment.
This looks to be the opposite of the diagram (for example, here it says that left is +X, but the diagram says right is +X). Which one is correct?
There was a problem hiding this comment.
The text one is correct.
There was a problem hiding this comment.
In that case we should probably reach out to @Cykyrios so they can update the diagram.
Calinou
left a comment
There was a problem hiding this comment.
Looks good to me in terms of content. I requested some stylistic changes. Also, all tabs should be replaced by 4 spaces in code samples (we currently follow different guidelines in the docs compared to the engine). Trailing whitespace should also be removed.
| See `the article on GyroWiki here <http://gyrowiki.jibbsmart.com/blog:good-gyro-controls-part-1:the-gyro-is-a-mouse>` | ||
| for information on how to use gyroscope input as a mouse. |
There was a problem hiding this comment.
| See `the article on GyroWiki here <http://gyrowiki.jibbsmart.com/blog:good-gyro-controls-part-1:the-gyro-is-a-mouse>` | |
| for information on how to use gyroscope input as a mouse. | |
| See `the article on GyroWiki <http://gyrowiki.jibbsmart.com/blog:good-gyro-controls-part-1:the-gyro-is-a-mouse>`__ | |
| for information on how to use gyroscope input as a mouse. |
PS: That website triggers an HTTP-only warning on Firefox in strict mode. @JibbSmart Could you look into setting up HTTPS with e.g. Let's Encrypt? This would avoid the warning.
|
might wanna include Fortnite as part of the example, given it's one of the biggest multiplayer game to include Gyro Aiming and is set as baseline example on how to do Gyro Aim. that, and it's created by the person behind GamepadMotionHelper. |
0220b24 to
e4d9d98
Compare
89bec82 to
f9cc280
Compare
|
Thank you for your review, AThousandShips! :) |
Co-Authored-By: Malcolm Anderson <malcolminyo@gmail.com> Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> Co-Authored-By: Cyril Bissey <53737317+Cykyrios@users.noreply.github.com> Co-Authored-By: Hugo Locurcio <hugo.locurcio@hugo.pro>
f9cc280 to
4848b70
Compare
|
Thank you for your review, Calinou! :) |
|
Thanks! |
Partially addresses #11466
Follow-up to godotengine/godot#111679
The gyroscope calibration explanation was borrowed from https://github.com/JibbSmart/GamepadMotionHelpers?tab=readme-ov-file#gyro-calibration
TODO: