RID_Owner: Fix race conditions due to missing synchronization#114980
Closed
RandomShaper wants to merge 1 commit intogodotengine:masterfrom
Closed
RID_Owner: Fix race conditions due to missing synchronization#114980RandomShaper wants to merge 1 commit intogodotengine:masterfrom
RandomShaper wants to merge 1 commit intogodotengine:masterfrom
Conversation
RandomShaper
added
bug
topic:core
needs testing
cherrypick:4.5
Contributor
|
This doesn't fix it on my M4 Pro MBP. |
Member
Author
|
@blueskythlikesclouds, thanks a lot for testing! Could you please try with Initially, I deemed true memory fences as not needed on ARM due to its data dependency tracking. However, it may be the case that some logic in |
RandomShaper
force-pushed
the
fix_rid_sync
branch
from
57c7234 to
5ed8054
Compare
Contributor
Still not fixed unfortunately. |
Member
akien-mga
added
archived
and removed
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If my assessment is correct, this would fix the issue. However, this topic is tricky enough for me not to take it for granted. In fact, the issue exists because of a mistake from me in the first place.
Fixes #114900.
Alernative to #114937.