Core: Switch RID_Alloc::owns to lock-free (reverted)#112657
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 12, 2025
Merged
Core: Switch RID_Alloc::owns to lock-free (reverted)#112657Repiteo merged 1 commit intogodotengine:masterfrom
RID_Alloc::owns to lock-free (reverted)#112657Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
RandomShaper
approved these changes
Nov 12, 2025
Member
RandomShaper
left a comment
RandomShaper
left a comment
There was a problem hiding this comment.
Makes sense and looks fine to me.
Contributor
|
Thanks! |
akien-mga
changed the title
RID_Alloc::owns to lock-freeRID_Alloc::owns to lock-free (reverted)
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Whilst working on #112481 and running various benchmarks, including an MRP that @clayjohn created to test #104194, I observed 7% of the total CPU time was spent in
RenderingDevice::texture_is_valid, which in turn callsRID_Alloc::owns. It isownsthat spent most of its time acquiring and releasing a mutex. TheRID_Alloc::get_or_nullAPI uses atomics for a lock-free approach, which can also be applied toowns, givenget_or_nullalso performs the validation. After the change,texture_is_validdrops from 7.3% to 1.3%: