Fix MSAA crashing Mali GPUs when using subpasses. #114785
Merged
+13
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We're definitely gonna need some more justification or at least some comments linking back to this PR explaining why such a restriction is imposed, since I could easily see someone modifying this back and breaking this hardware in the process. |
blueskythlikesclouds
force-pushed
the
mali-msaa-subpass-fix
branch
from
0d0cc5b to
7158224
Compare
Contributor
Author
Done that. |
Alex2782
approved these changes
Jan 10, 2026
Member
Alex2782
left a comment
Alex2782
left a comment
There was a problem hiding this comment.
That looks good!
On my Chromebook Mali-G52 no crash with this PR.
Galaxy XCover Pro, Mali-G72 (on Firebase Test Lab)
mali fixis this PR- without label is
beta2
Test videos
this PR
web-build_20260110_w2fk_xcoverpro-33-en_US-landscape_video.mp4
Beta 2
The app freezes and crashes (is terminated by Android OS).
web-build_20260110_h7r4_xcoverpro-33-en_US-landscape_video.mp4
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112530, at least on the Mali-G76 phone I have.
I was just randomly trying things hoping it shows different behavior and this somehow fixed the crash. Before this, I tried spreading the uniforms to 4 sets to match the old layout, but that was still crashing. It seems specifically only one set fixes it. Unfortunately, I don't have the slightest clue why.
Needs testing to see if it also fixes it for other Mali GPUs.