Fix specialization constant patching on D3D12.#111356
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 13, 2025
Merged
Fix specialization constant patching on D3D12.#111356Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
added
cherrypick:4.4
blueskythlikesclouds
force-pushed
the
d3d12-spec-constant-patch-fix
branch
2 times, most recently
from
5458698 to
c26d71f
Compare
clayjohn
removed
cherrypick:4.4
Repiteo
requested changes
Oct 7, 2025
Contributor
Repiteo
left a comment
Repiteo
left a comment
There was a problem hiding this comment.
Local dev builds fail from the sign change. Given the lambda already expects a uint64_t, we should be doing the same with the base variable
Repiteo
reviewed
Oct 7, 2025
blueskythlikesclouds
force-pushed
the
d3d12-spec-constant-patch-fix
branch
from
c26d71f to
36b7e77
Compare
Repiteo
approved these changes
Oct 13, 2025
Contributor
|
Thanks! |
This was referenced Oct 17, 2025
akien-mga
added
the
cherrypick:4.5
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100138.
The specialization constant patching code was rejecting signed values, assuming it needed to set the MSB to respect LLVM IR's VBR encoding. However, as explained here, the contents of the integer actually do not matter at all, because we can just keep emitting continue bits even if the bits are all zero.
Godot already uses an appropriate sentinel value to enforce 32 bits in the output bytecode, so this approach works fine.