Remove 0xbfffffff bitmask from specialization constants.#22
Merged
bruvzg merged 1 commit intogodotengine:masterfrom Nov 3, 2025
Merged
Conversation
blueskythlikesclouds
force-pushed
the
remove-bit-masking
branch
from
d50aa05 to
c2ae0c3
Compare
bruvzg
approved these changes
Nov 2, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Change seems reasonable, and I have not encountered any issues with it.
akien-mga
added a commit
to godotengine/godot-build-scripts
that referenced
this pull request
Nov 3, 2025
akien-mga
added a commit
to godotengine/godot-build-scripts
that referenced
this pull request
Nov 4, 2025
akien-mga
added a commit
to godotengine/godot-build-scripts
that referenced
this pull request
Jan 9, 2026
Companion PR to: - godotengine/godot-nir-static#22 - godotengine/godot-nir-static#23 - godotengine/godot#111762 (cherry picked from commit 7126657)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR to godotengine/godot#111356.
Partners with godotengine/godot#111762.
Since we allow all of the specialization constant bits now, we shouldn't mask out the second MSB.