Improve and optimize lightmap probe gizmo creation #105568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCube3310
force-pushed
the
lightprobe-gizmo-opti
branch
from
e44664f to
c96fea3
Compare
BlueCube3310
force-pushed
the
lightprobe-gizmo-opti
branch
from
c96fea3 to
fbadaa2
Compare
clayjohn
approved these changes
Apr 19, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the gizmo creation process by using
LocalVectorto avoid COW. Additionally, the Spherical Harmonics are evaluated the same way as in #105525On a debug build, the function execution time goes from ~52ms to ~30ms.