Scene shader: Improve and document SH diffuse evaluation for light probes #105525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the spherical harmonics evaluation code based on https://github.com/kayru/Probulator/blob/master/Source/Probulator/SphericalHarmonics.h and https://cseweb.ucsd.edu/~ravir/papers/envmap/envmap.pdf .
As a result, the coefficients in the diffuse evaluation process more closely resemble the ones from the lightmapper, making the code slightly easier to comprehend.
Additionally, the magic numbers resulting from the convolution of directional SH are documented as equations.
Resulting numbers comparison: