Fix GDExtension Object/Node::to_string to check is_valid before returning the result#105546
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Apr 28, 2025
Merged
Conversation
…ning the result at best, this results in an empty string, at worst, the result is never initialised when is_valid is false.
AThousandShips
changed the title
Object/Node::to_string to check is_valid before returning the result
dsnopek
approved these changes
Apr 21, 2025
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Good catch, thanks! These changes look correct to me
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At best, this results in an empty string, at worst, the result is never initialized when is_valid is false.