Properly set GDExtensionBool is_valid to true in to_string function.#1145
Merged
Bromeon merged 2 commits intogodot-rust:masterfrom Apr 28, 2025
Merged
Conversation
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1145 |
Bromeon
added
the
c: ffi
Bromeon
approved these changes
Apr 28, 2025
Member
|
Canceled merge and added commit that resets CI back to latest nightly Godot, undoing the temporary fix in #1143. This way, we actually test if itests pass with Godot changes in godotengine/godot#105546 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it does what it says on the tin, duh.
GDExtension never checked this bool before: godotengine/godot#105546. It was never initialized by either side (UB: https://doc.rust-lang.org/reference/behavior-considered-undefined.html#r-undefined.validity.undef)