Fix viewport rotation gizmo aligned axis reversing #101209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
added
the
cherrypick:4.4
ryevdokimov
force-pushed
the
fix-viewport-rotation-aligned-axis-reversing
branch
from
7a20d8d to
5d501f2
Compare
Repiteo
added
the
cherrypick:4.5
ryevdokimov
force-pushed
the
fix-viewport-rotation-aligned-axis-reversing
branch
from
5d501f2 to
fcdf68a
Compare
ryevdokimov
force-pushed
the
fix-viewport-rotation-aligned-axis-reversing
branch
from
fcdf68a to
de29136
Compare
ryevdokimov
force-pushed
the
fix-viewport-rotation-aligned-axis-reversing
branch
from
de29136 to
c65d71a
Compare
TokageItLab
approved these changes
Jan 15, 2026
Member
There was a problem hiding this comment.
In #76052, what I fixed was that when the camera was parallel to the axis, the axis button display itself was inverted. Specifically, in Front View, the -Z (dark blue) button was displayed, resulting in an inconsistency where the button did not correctly indicate the user's current position. So I have fixed that.
In this PR, it internally adds a flag to determine if the clicking result should be inverted in that case. So the drawing itself remains unchanged. Since this approach maintains display consistency, I think it's fine to merge this and allow axis inversion by clicking.
Member
|
Thanks! |
akien-mga
removed
cherrypick:4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #101172
This PR reverts part of #76052 which caused the regression by effectively disabling the order flipping for the aligned axis that allowed you to click the axis to reverse. The fix should be to redraw the aligned axis in reverse so that it still looks correct.
2025-01-06.23-41-03.mp4