Prevent errors when drawing debug meshes with no mesh data. #101014
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
Adds a few checks to ensure a debug collision mesh contains mesh data before attempting to add it to the gizmo draw list. This prevents errors when using SeparationRayShape3D, which is only intended to draw a single line, and contains no mesh data. Closes godotengine#100665
BattyBovine
force-pushed
the
cs3d-separation-ray-fix-2
branch
from
778571c to
a7810e8
Compare
This should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few checks to ensure a debug collision mesh contains mesh data before attempting to add it to the gizmo draw list. This prevents errors when using
SeparationRayShape3D, which is only intended to draw a single line, and contains no mesh data.Closes #100665
This fixes the same issue as #100968, just using a different method that performs a check for null mesh data before adding the debug mesh. This is probably the more proper fix, but I'll leave the other pull request open for now.