Wayland: Godot v4.3 beta3 crashes when running on linux

[em-s-h]

Tested versions

• Reproducible in Godot v4.3 beta3 only.

System information

Godot v4.3.beta3.official.82cedc83c Arch Linux #1 SMP PREEMPT_DYNAMIC Fri, 05 Jul 2024 22:11:24 +0000 - Wayland - Vulkan (Forward+) - integrated Intel(R) HD Graphics 5500 (BDW GT2) () - Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 Threads)

Issue description

Godot will instantly crash after starting when running under wayland, using --display-driver x11 will make godot start normally.

Error message:

xdg_surface#41: error 3: xdg_surface has never been configured
ERROR: Wayland protocol error 3 on interface xdg_surface@41.
   at: _poll_events_thread (platform/linuxbsd/wayland/wayland_thread.cpp:2739)

================================================================
handle_crash: Program crashed with signal 4
Engine version: Godot Engine v4.3.beta3.official (82cedc83c9069125207c128f9a07ce3d82c317cc)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /usr/lib/libc.so.6(+0x3cae0) [0x70cbcbe59ae0] (??:0)
[2] godot_v4.3-beta3() [0x487dd7] (??:0)
[3] godot_v4.3-beta3() [0x3e3a645] (??:0)
[4] godot_v4.3-beta3() [0x4adff23] (??:0)
[5] /usr/lib/libc.so.6(+0x92ded) [0x70cbcbeafded] (??:0)
[6] /usr/lib/libc.so.6(+0x1160dc) [0x70cbcbf330dc] (??:0)
-- END OF BACKTRACE --
================================================================
Aborted (core dumped)

Steps to reproduce

Run ./Godot_v4.3-beta3_linux.x86_64 under wayland.

Minimal reproduction project (MRP)

N/A

[Riteo]

Thanks for your report! Could you please attach a verbose log with WAYLAND_DEBUG=1?

The command should look something like this: WAYLAND_DEBUG=1 godot --verbose > wayland.log 2>&1

[BasilYes]

Thanks for your report! Could you please attach a verbose log with WAYLAND_DEBUG=1?

The command should look something like this: WAYLAND_DEBUG=1 godot --verbose > wayland.log 2>&1

Very similar bug, I'm using hyprland crush on two different pc (with nvidia gpu and amd gpu)
No crash on earlier beta versions.
One with amd gpu:
NixOS #1-NixOS ZEN SMP PREEMPT_DYNAMIC Tue Jan 1 00:00:00 UTC 1980 - Wayland - Vulkan (Forward+) - integrated AMD Radeon Graphics (RADV RENOIR) - AMD Ryzen 5 5500U with Radeon Graphics (12 Threads)

Log here
wayland.log

(If it's not the same issue, tell me, I will open new issue)

[em-s-h]

Thanks for your report! Could you please attach a verbose log with WAYLAND_DEBUG=1?

The command should look something like this: WAYLAND_DEBUG=1 godot --verbose > wayland.log 2>&1

Here it is:
wayland.log

[Riteo]

Thank you folks! You are both having the same issue and I can see it perfectly. A fix is coming soon :)

[Riteo]

Ok, sorry, for the delay, I just gave a look at this.

The issue is still very clear: this is surely a regression caused by #93684, as I forgot to account for the initialization of xdg_surfaces. I'm making a PR as we speak which should fix your case.

Curiously, I can't seem to replicate it on sway (although patched with explicit sync so TIWAGOS) even without libdecor.

@BasilYes reported hyprland; @em-s-h, what are you using instead?

Update: I can replicate this on Weston! No idea what's going on in my sway install, but this will do for testing on my part :D

[em-s-h]

what are you using instead?

I'm using sway

[Riteo]

I'm using sway

All right. I think my sway version is borked then, I should really switch back to the main branch 😅

[Riteo]

BTW, I pushed the super-tiny patch. That line got removed by accident as it was commented in a deceiving way. Feel free to try it :D

[Riteo]

Oops, closed this by accident, sorry!