Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKER] Wayland issues #88346

Open
17 of 35 tasks
Riteo opened this issue Feb 14, 2024 · 14 comments
Open
17 of 35 tasks

[TRACKER] Wayland issues #88346

Riteo opened this issue Feb 14, 2024 · 14 comments

Comments

@Riteo
Copy link
Contributor

Riteo commented Feb 14, 2024

Tested versions

  • Reproducible in: 4.3.dev3 and later

System information

Linux/BSD - Wayland backend

Issue description

A new, experimental and opt-in Wayland backend got merged in 4.3.dev3.

While it got tested plenty, there are still quite a bunch of missing features and lots of things to improve, which are tracked in this issue.

Tasks

  1. bug platform:linuxbsd topic:editor topic:porting
  2. bug platform:linuxbsd topic:editor topic:porting
  3. bug platform:linuxbsd topic:porting topic:shaders
    Riteo
  4. bug crash needs testing platform:linuxbsd topic:porting
  5. bug platform:linuxbsd topic:editor topic:porting
  6. bug platform:linuxbsd topic:porting
  7. bug performance platform:linuxbsd topic:particles
  8. bug platform:linuxbsd topic:input
  9. bug platform:linuxbsd topic:porting
  10. bug confirmed platform:linuxbsd topic:porting
  11. bug platform:linuxbsd topic:porting
  12. bug platform:linuxbsd topic:porting
  13. bug platform:linuxbsd topic:porting
  14. bug crash platform:linuxbsd topic:porting
    Riteo
  15. bug platform:linuxbsd topic:porting
  16. bug platform:linuxbsd topic:porting
  17. bug needs testing platform:linuxbsd topic:editor
    Riteo
  18. enhancement platform:linuxbsd topic:input topic:porting usability
    bruvzg
  19. bug platform:linuxbsd topic:porting
  20. bug platform:linuxbsd topic:gui
  21. bug platform:linuxbsd topic:porting
  22. bug platform:linuxbsd topic:editor
    Riteo
  23. bug platform:linuxbsd topic:gui
    Riteo
  24. bug crash platform:linuxbsd regression topic:porting
    Riteo
  25. bug platform:linuxbsd regression topic:gui
    Riteo
  26. bug platform:linuxbsd topic:editor topic:porting
  27. bug platform:linuxbsd topic:input topic:porting
  28. bug platform:linuxbsd topic:input topic:porting
  29. bug platform:linuxbsd topic:input topic:porting
  30. bug needs testing platform:linuxbsd topic:porting
  31. bug performance platform:linuxbsd topic:porting
  32. bug platform:linuxbsd topic:buildsystem
    Riteo
  33. bug platform:linuxbsd topic:porting
  34. bug platform:linuxbsd topic:editor
  35. bug platform:linuxbsd topic:editor topic:porting

Steps to reproduce

From the CLI: start the engine with the --display-driver wayland flag.

Alternatively, for the editor: set the run/platforms/linuxbsd/prefer_wayland editor setting to true or, for running projects, set the display/display_server/driver.linuxbsd project setting to wayland.

Minimal reproduction project (MRP)

N/A

@Roogephy

This comment was marked as resolved.

@Riteo

This comment was marked as resolved.

@aylamz

This comment was marked as resolved.

@Riteo

This comment was marked as resolved.

@aylamz

This comment was marked as resolved.

@BiosElement
Copy link

BiosElement commented Apr 9, 2024

Edit: , I am not confident it isn't a KDE related issue, but am not in a position to test it on other DE's currently.

This is an example: https://youtu.be/Xr5cmBRonls

Has anyone ran into a really strange issue where trying to resize a windowed instance of Godot under Wayland/KDE causes it to move way up off the top left edge of the screen at a massive scale? It does not replicate under X11, but it is such a strange thing I don't really have enough to file a useful report.

I am using a laptop display at 2256x1504 and a desktop monitor at 2569x1440. I have confirmed it does not matter if the second display is connected or not, the issue still occurs with only the laptop display connected.

This was all found using the git build of Godot as-of 4/8/24, it is not present in stable.

Update: I have narrowed this down to being introduced between cd4e4c0 and b926e51. Narrowing down still.
Update 2: Issue occurs with 34f284b. Issue partially occurs with 5cf6f3c, it does resize correctly but does so very slowly before crashing.

Reproducible in:
b926e51
7901a05

@Roogephy

This comment was marked as resolved.

@Riteo
Copy link
Contributor Author

Riteo commented Apr 19, 2024

Hi folks, sorry for the delay, I couldn't work on this stuff in the last few weeks. I just got back! :D

@Roogephy thanks for the report! I'll explain the situation a bit more thoroughly there once I get back to speed. I'll put the issue in the tracker and mark the relevant messages as "resolved" to not clutter the thread too much.

Hi @BiosElement, this issue feels quite complicated and I'm not sure how the bisected commits relate to this at all. That said, I recommend to file a dedicated issue ticket so that we can investigate further without cluttering up this thread.

@Sauermann

This comment was marked as resolved.

@Riteo

This comment was marked as resolved.

@sullyj3

This comment was marked as resolved.

@eobet
Copy link
Contributor

eobet commented Aug 3, 2024

Sorry, but does anyone else "feel" a difference between regular and "Prefer Wayland" setting? I don't know how to see the framerate of the editor, but I have a 120hz display and it feels like 20-30 when I enable Wayland (but other apps are fine and mouse gestures are super smooth too). This is using "single window mode" as well, btw.

@Riteo
Copy link
Contributor Author

Riteo commented Aug 14, 2024

@eobet sorry for the delay.

That's quite weird. You could try running the editor directly by opening a project.godot file and pass the --print-fps flag: godot --print-fps path/to/project.godot

You should then see the framerate being printed into the standard output every few seconds.

If there's a substantial difference in framerate between the wayland and the x11 backend, please file a new ticket.

This is using "single window mode" as well, btw.

Note that, due to various reasons, the Wayland backend is forced to the single window mode for the time being. I'm researching the steps needed for a proper multi-window implementation.

If you see multiple native windows, then you're running the X11 backend through XWayland.

@perroboc

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

8 participants