Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopupMenu horizontal margins in the editor theme became too low since 4.3.dev3 #89697

Open
Calinou opened this issue Mar 19, 2024 · 0 comments · May be fixed by #95949
Open

PopupMenu horizontal margins in the editor theme became too low since 4.3.dev3 #89697

Calinou opened this issue Mar 19, 2024 · 0 comments · May be fixed by #95949

Comments

@Calinou
Copy link
Member

Calinou commented Mar 19, 2024

Tested versions

  • Reproducible in: 4.3.dev3, 4.3.dev4, 4.3.dev fe01776
  • Not reproducible in: 4.2.1.stable, 4.3.dev2

System information

Godot v4.3.dev (fe01776) - Fedora Linux 39 (KDE Plasma) - Wayland - GLES3 (Compatibility) - NVIDIA GeForce RTX 4090 (nvidia; 545.29.06) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)

Issue description

PopupMenu horizontal margins in the editor theme became too low since 4.3.dev3. This makes popups feel less consistent with the rest of the editor theme (and most other applications).

Look at the space between the edge of the popup and the New Scene text:

4.3.dev1 4.3.dev4
editor_popupmenu_4 3 dev1 editor_popupmenu_4 3 dev4

Back-and-forth animation to compare:

comparison webp

I bisected the regression to dc3b07e (#87085).

While we're at it, we may want to further increase this horizontal margin to make it closer to most other applications (example with a Qt dropdown on KDE Breeze theme):

qt_dropdown

Steps to reproduce

  • Open any popup or dropdown in the editor.

Minimal reproduction project (MRP)

N/A

@Calinou Calinou added this to the 4.3 milestone Mar 19, 2024
@KoBeWi KoBeWi moved this from Unassessed to Not Critical in 4.x Release Blockers Jul 30, 2024
@KoBeWi KoBeWi modified the milestones: 4.3, 4.4 Jul 30, 2024
@Giganzo Giganzo linked a pull request Aug 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants