Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU Particles have very slow framerate on Wayland #88248

Closed
Tracked by #88346
pracedru opened this issue Feb 12, 2024 · 9 comments · Fixed by #87750
Closed
Tracked by #88346

GPU Particles have very slow framerate on Wayland #88248

pracedru opened this issue Feb 12, 2024 · 9 comments · Fixed by #87750

Comments

@pracedru
Copy link

Tested versions

  • Reproducible in: Godot v4.3.dev3

System information

Godot v4.3.dev3.mono - Fedora Linux 39 (Workstation Edition) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (RADV NAVI22) () - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)

Issue description

GPU particles seem to run at something like 1/100 speed.

2024-02-12.15-11-51.mp4

Steps to reproduce

  1. Open Godot with --display-driver wayland.
  2. Open MRP
  3. Observe Particle systems

Minimal reproduction project (MRP)

mrpwp.zip

@DarioSamo
Copy link
Contributor

DarioSamo commented Feb 12, 2024

That's curious because they literally can't run asynchronously from the rest of the rendering loop, and clearly your frame rate is fine. Perhaps the time where it sources the data from for running the compute shader is broken in Wayland?

@pracedru
Copy link
Author

That's curious because they literally can't run asynchronously from the rest of the rendering loop, and clearly your frame rate is fine. Perhaps the time where it sources the data from for running the compute shader is broken in Wayland?

I was thinking that it wasn't performance related by deltatime related.

@Calinou
Copy link
Member

Calinou commented Feb 12, 2024

This is likely due to the same cause as #87963. Can you test #87750 locally?

@pracedru
Copy link
Author

This is likely due to the same cause as #87963. Can you test #87750 locally?

I am building this branch now.

@pracedru
Copy link
Author

Hi @Calinou, I can confirm that particles runs as expected with this branch under wayland.

@akien-mga
Copy link
Member

akien-mga commented Feb 15, 2024

I tested both master and #87750, and strangely enough I can't reproduce the bug with the MRP here (but I could reproduce the bug from #87963).

Either way, if it works for @pracedru it's likely good to go anyway :)

@Riteo
Copy link
Contributor

Riteo commented Feb 15, 2024

@akien-mga uh right, that's another thing of that issue, it's metastable lol. It will fall in into either state: consistently refresh rate or into the tickrate for some reason.

Edit: Oh wait you said that you could reproduce the TIME thing though. Not sure what's goung on the, as long as it works 🤷

@pracedru
Copy link
Author

@akien-mga uh right, that's another thing of that issue, it's metastable lol. It will fall in into either state: consistently refresh rate or into the tickrate for some reason.

Edit: Oh wait you said that you could reproduce the TIME thing though. Not sure what's goung on the, as long as it works 🤷

Could my recent change in hardware be the reason why it works on my end?

@pracedru
Copy link
Author

No I just reproduced the issue with the official dev3 build on my current setup.
So it seems to have been fixed with this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants