Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to know in-editor if sub-resources are unique or not #6258

Closed
marcelofg55 opened this issue Aug 23, 2016 · 7 comments
Closed

A way to know in-editor if sub-resources are unique or not #6258

marcelofg55 opened this issue Aug 23, 2016 · 7 comments

Comments

@marcelofg55
Copy link
Contributor

Hi, if you duplicate for example an AnimationPlayer its sub-resources remain linked and on the editor there is no way to determine if the sub-resources are unique or not. The only way now is to check the .tscn file.
So I was thinking that perhaps a good solution for this would be to show the list of sub-resources ids used by the node on the Inspector, I could try to implement this as well but I would like to know first if you agree with this or not :)

@vnen vnen changed the title [Feature Proposal] Implement a way to know if sub-resources are unique or not. A way to know in-editor if sub-resources are unique or not Aug 23, 2016
@reduz
Copy link
Member

reduz commented Aug 24, 2016

There is no need, sub-resources are never unique, always shared.

On Tue, Aug 23, 2016 at 1:06 PM, Marcelo Fernandez <[email protected]

wrote:

Hi, if you duplicate for example an AnimationPlayer its sub-resources
remain linked and on the editor there is no way to determine if the
sub-resources are unique or not. The only way now is to check the .tscn
file.
So I was thinking that perhaps a good solution for this would be to show
the list of sub-resources ids used by the node on the Inspector, I could
try to implement this as well but I would like to know first if you agree
with this or not :)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6258, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2-OMeZMBhZredmqPbPHHOfnvnTi4ks5qixqGgaJpZM4JrGhp
.

@marcelofg55
Copy link
Contributor Author

I see, the "Make Sub-Resources Unique" button is a bit confusing then. Could a unique flag be implemented for sub-resources?

@reduz
Copy link
Member

reduz commented Aug 24, 2016

Make sub-resources unique just makes a copy, they are never unique

On Wed, Aug 24, 2016 at 8:49 AM, Marcelo Fernandez <[email protected]

wrote:

I see, the "Make Sub-Resources Unique" button is a bit confusing then.
Could a unique flag be implemented for sub-resources?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6258 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2zYSZ5D3qSpCyvjVpDXuFO2iLy1Kks5qjC_fgaJpZM4JrGhp
.

@reduz
Copy link
Member

reduz commented Aug 24, 2016

Maybe the text could be better, I'm not exactly sure what it could say.
I was considering adding a flag to make resources unique for the scene, but
that would still not solve your problem I guess.

On Wed, Aug 24, 2016 at 9:03 AM, Juan Linietsky [email protected] wrote:

Make sub-resources unique just makes a copy, they are never unique

On Wed, Aug 24, 2016 at 8:49 AM, Marcelo Fernandez <
[email protected]> wrote:

I see, the "Make Sub-Resources Unique" button is a bit confusing then.
Could a unique flag be implemented for sub-resources?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6258 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2zYSZ5D3qSpCyvjVpDXuFO2iLy1Kks5qjC_fgaJpZM4JrGhp
.

@marcelofg55
Copy link
Contributor Author

It would be nice to have that flag implemented, and then the flag is shown on the gui and issue solved :)

@reduz
Copy link
Member

reduz commented Aug 24, 2016

It would be relatively easy to do, but It would only work for resources
that are directly placed on a node..

On Wed, Aug 24, 2016 at 9:11 AM, Marcelo Fernandez <[email protected]

wrote:

It would be nice to have that flag implemented, and then the flag is shown
on the gui and issue solved :)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6258 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z27x6U6oitFOqt7p248M9oI_KXISKks5qjDT_gaJpZM4JrGhp
.

@akien-mga
Copy link
Member

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.

The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.

If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants