Duplicating a tree with animation breaks the original tree.

[studioschade]

Operating system or device - Godot version:
Windows 7, Godot 2.1.1

Issue description (what happened, and what was expected):
When a scene tree is duplicated and contains an animation, it seems it tries to fix the new animation to match the new node. It also seems to change the original animation to match the new node, thus breaking it.

Steps to reproduce:
Make a subtree in a scene which contains an animation, duplicate it.

[puppetmaster-]

The problem is duplicating don't make the subResources(Animation) unique.
#3222
#6258

[bojidar-bg]

Marking as confirmed since I think I saw it a few weeks ago on 2.1/HEAD.

[volzhs]

And also merging from another scene has same issue on 2.2-legacy.

[ghost]

First of all thank you for your report and sorry for the delay.

We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.

We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about it here?

For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.

Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.

Thanks in advance.

Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

[volzhs]

This reminds me a PR related to this. (can't remember which one)
I made a simple test for this.

- Sprite A
    - AnimationPlayer
- Sprite B  // this is duplicated with "Sprite A" contains AnimationPlayer
    - AnimationPlayer

1. add Sprite
2. add AnimationPlayer under Sprite
3. create an animation
4. duplicate Sprite
5. change animation in duplicated AnimationPlayer node
6. see the animation of original AnimationPlayer is not changed
7. close scene & reopen
8. those 2 animation has own different animation

tested 3.1.dev cb7fe2c
I think it's fixed now.

[Piet-G]

This is indeed fixed in master, but still relevant in 2.1

[akien-mga]

Thanks, closing as fixed in 3.1 then. At this stage only critical bug fixes will still be considered for the 2.1 branch.