Replace dropzone with @deltablot/dropzone#37237
Merged
silverwind merged 2 commits intogo-gitea:mainfrom Apr 17, 2026
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
Member
|
Was it tested? I imagine there might be incompatibilties. We don't have test coverage on this, but some basic e2e tests could be added. |
Contributor
Author
|
@silverwind I did a manual test of dragging and uploading file to git repo
and issue editor and did not see anywhere else wrong. I'm not sure what
else to test.
I read dropzone changelog and did not find anything possibly breaking the
frontend.
… |
Member
|
Ok, I will do a manual test later. Maybe also add a e2e test. |
Member
|
Manually tested, works fine. Package also reviewed, looks like a strict drop-in replacement, no concerns. |
silverwind
approved these changes
Apr 16, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 16, 2026
GiteaBot
added
lgtm/done
silverwind
changed the title
dropzone with @deltablot/dropzone
Collaborator
|
I was unable to create a backport for 1.26. @PineBale, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 17, 2026
* main: Replace `dropzone` with `@deltablot/dropzone` (go-gitea#37237) Add `ExternalIDClaim` option for OAuth2 OIDC auth source (go-gitea#37229) Remove error returns from crypto random helpers and callers (go-gitea#37240) Use Content-Security-Policy: script nonce (go-gitea#37232) Remove htmx (go-gitea#37224) Refactor "htmx" to "fetch action" (go-gitea#37208) Fix UI regression (go-gitea#37218) Fix corrupted JSON caused by goccy library (go-gitea#37214) Add test for "fetch redirect", add CSS value validation for external render (go-gitea#37207) Fix incorrect concurrency check (go-gitea#37205) refactor: simplify ParseCatFileTreeLine and catBatchParseTreeEntries (go-gitea#37210) Update go js py dependencies (go-gitea#37204)
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Apr 17, 2026
Fix go-gitea#37228. Using NicolasCARPi/dropzone as short-term solution (cherry picked from commit 2bfaa33)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #37228.
Using NicolasCARPi/dropzone as short-term solution