Skip to content

Update golangci-lint to v2.11.4#37059

Merged
silverwind merged 2 commits intogo-gitea:mainfrom
silverwind:update-golangci-lint-v2.11.4
Mar 31, 2026
Merged

Update golangci-lint to v2.11.4#37059
silverwind merged 2 commits intogo-gitea:mainfrom
silverwind:update-golangci-lint-v2.11.4

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Mar 31, 2026

Update golangci-lint from v2.11.2 to v2.11.4 and fix new modernize lint warnings:

  • Use strings.Builder instead of string concatenation in loop (evaluator.go)
  • Use atomic.Int64 instead of int64 with atomic free functions (logchecker.go, timer_test.go, integration_test.go)

This PR was written with the help of Claude Opus 4.6

@silverwind @claude
Update golangci-lint to v2.11.4 and fix lint issues
e60f559 
Update golangci-lint from v2.11.2 to v2.11.4 and fix new modernize
lint warnings: use strings.Builder instead of string concatenation in
loop, and use atomic.Int64 instead of int64 with atomic free functions.

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 31, 2026
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/internal labels Mar 31, 2026
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 31, 2026
@silverwind silverwind requested a review from Copilot March 31, 2026 15:13
Copilot AI reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s pinned golangci-lint tool version and adjusts a few Go call sites to satisfy new modernize lint expectations introduced by the linter update.

Changes:

  • Bump golangci-lint from v2.11.2 to v2.11.4 in the Makefile tool pin.
  • Refactor loop-based string construction in the actions job parser evaluator to use strings.Builder.
  • Replace int64 + sync/atomic free-function usage with atomic.Int64 in test and test-helper code.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Makefile Updates the pinned golangci-lint tool version to v2.11.4.
modules/actions/jobparser/evaluator.go Uses strings.Builder for incremental format string construction to satisfy modernize.
modules/test/logchecker.go Switches global counter to atomic.Int64 and uses its methods.
modules/util/timer_test.go Updates debounce test counter to atomic.Int64 APIs.
tests/integration/integration_test.go Updates integration token uniqueness counter to atomic.Int64 APIs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 31, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2026
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2026
@silverwind silverwind enabled auto-merge (squash) March 31, 2026 15:49
@silverwind silverwind merged commit d8da91a into go-gitea:main Mar 31, 2026
26 checks passed
@silverwind silverwind deleted the update-golangci-lint-v2.11.4 branch March 31, 2026 16:22
@GiteaBot GiteaBot added this to the 1.26.0 milestone Mar 31, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2026
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 1, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into darkmono
52658d0 
* origin/main:
  Update JS dependencies and misc tweaks (go-gitea#37064)
  Redirect to the only OAuth2 provider when no other login methods and fix various problems (go-gitea#36901)
  Show workflow link (go-gitea#37070)
  Remove leftover `webpackChunkName` comments from codeeditor (go-gitea#37062)
  Update Go dependencies (go-gitea#36781)
  Add webhook name field to improve webhook identification (go-gitea#37025) (go-gitea#37040)
  Upgrade `go-git` to v5.17.2 (go-gitea#37060)
  Replace Monaco with CodeMirror (go-gitea#36764)
  Update Combine method to treat warnings as failures and adjust tests (go-gitea#37048)
  Raise minimum Node.js version to 22.18.0 (go-gitea#37058)
  Update golangci-lint to v2.11.4 (go-gitea#37059)
  Upgrade `golang.org/x/image` to v0.38.0 (go-gitea#37054)

# Conflicts:
#	web_src/css/themes/theme-gitea-dark.css
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 2, 2026
@zjjhot
Merge branch 'main' into mainzjj
0646014 
* main:
  Fix NuGet package upload error handling (go-gitea#37074)
  Desaturate dark theme background colors (go-gitea#37056)
  Update JS dependencies and misc tweaks (go-gitea#37064)
  Redirect to the only OAuth2 provider when no other login methods and fix various problems (go-gitea#36901)
  Show workflow link (go-gitea#37070)
  Remove leftover `webpackChunkName` comments from codeeditor (go-gitea#37062)
  Update Go dependencies (go-gitea#36781)
  Add webhook name field to improve webhook identification (go-gitea#37025) (go-gitea#37040)
  Upgrade `go-git` to v5.17.2 (go-gitea#37060)
  Replace Monaco with CodeMirror (go-gitea#36764)
  Update Combine method to treat warnings as failures and adjust tests (go-gitea#37048)
  Raise minimum Node.js version to 22.18.0 (go-gitea#37058)
  Update golangci-lint to v2.11.4 (go-gitea#37059)
  Upgrade `golang.org/x/image` to v0.38.0 (go-gitea#37054)
  Increase e2e test timeouts on CI to fix flaky tests (go-gitea#37053)
  Refactor "org teams" page and help new users to "add member" to an org (go-gitea#37051)
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 2, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into feedcut
77eeee7 
* origin/main: (192 commits)
  Fix NuGet package upload error handling (go-gitea#37074)
  Desaturate dark theme background colors (go-gitea#37056)
  Update JS dependencies and misc tweaks (go-gitea#37064)
  Redirect to the only OAuth2 provider when no other login methods and fix various problems (go-gitea#36901)
  Show workflow link (go-gitea#37070)
  Remove leftover `webpackChunkName` comments from codeeditor (go-gitea#37062)
  Update Go dependencies (go-gitea#36781)
  Add webhook name field to improve webhook identification (go-gitea#37025) (go-gitea#37040)
  Upgrade `go-git` to v5.17.2 (go-gitea#37060)
  Replace Monaco with CodeMirror (go-gitea#36764)
  Update Combine method to treat warnings as failures and adjust tests (go-gitea#37048)
  Raise minimum Node.js version to 22.18.0 (go-gitea#37058)
  Update golangci-lint to v2.11.4 (go-gitea#37059)
  Upgrade `golang.org/x/image` to v0.38.0 (go-gitea#37054)
  Increase e2e test timeouts on CI to fix flaky tests (go-gitea#37053)
  Refactor "org teams" page and help new users to "add member" to an org (go-gitea#37051)
  Refactor issue sidebar and fix various problems (go-gitea#37045)
  Add tests for pull request's content_version in API (go-gitea#37044)
  Enable concurrent vitest execution (go-gitea#36998)
  Fix theme discovery and Vite dev server in dev mode (go-gitea#37033)
  ...

# Conflicts:
#	templates/user/dashboard/feeds.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@bircni bircni bircni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind @techknowlogick @bircni @GiteaBot