Enable concurrent vitest execution#36998
Merged
silverwind merged 4 commits intogo-gitea:mainfrom Mar 30, 2026
Merged
Conversation
Enable `sequence.concurrent` to run tests within files in parallel. Refactor branch settings tests to be concurrent-safe by tracking mock call count deltas instead of relying on shared state. Suppress expected console.error output in render-iframe tests. Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
silverwind
added
type/testing
skip-changelog
Contributor
There was a problem hiding this comment.
Pull request overview
Enables concurrent Vitest execution and adjusts tests to reduce reliance on shared mutable state, improving test suite runtime and aiming to surface concurrency issues earlier.
Changes:
- Enable
sequence.concurrentin Vitest configuration to run test files in parallel. - Refactor “Repository Branch Settings” tests to avoid global mock clearing and reduce shared-state coupling.
- Update iframe navigation test to locally suppress
console.erroroutput.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| web_src/js/markup/render-iframe.test.ts | Switches from clearing all mocks to restoring a specific console.error spy. |
| web_src/js/features/repo-settings-branches.test.ts | Refactors tests to avoid vi.clearAllMocks() and uses call-delta assertions to cope with shared mocks. |
| vitest.config.ts | Enables concurrent test-file execution via sequence.concurrent: true. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Restore the trailing vi.clearAllMocks() that was removed in the previous commit, and add errorSpy.mockRestore() before it to properly clean up both the test-scoped console.error spy and the describe-scoped mock call counts. Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
TheFox0x7
approved these changes
Mar 28, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 30, 2026
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 31, 2026
* main: Refactor issue sidebar and fix various problems (go-gitea#37045) Add tests for pull request's content_version in API (go-gitea#37044) Enable concurrent vitest execution (go-gitea#36998) Fix theme discovery and Vite dev server in dev mode (go-gitea#37033) bump snapcraft deps (go-gitea#37039) Expose content_version for optimistic locking on issue and PR edits (go-gitea#37035)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 2, 2026
* origin/main: (192 commits) Fix NuGet package upload error handling (go-gitea#37074) Desaturate dark theme background colors (go-gitea#37056) Update JS dependencies and misc tweaks (go-gitea#37064) Redirect to the only OAuth2 provider when no other login methods and fix various problems (go-gitea#36901) Show workflow link (go-gitea#37070) Remove leftover `webpackChunkName` comments from codeeditor (go-gitea#37062) Update Go dependencies (go-gitea#36781) Add webhook name field to improve webhook identification (go-gitea#37025) (go-gitea#37040) Upgrade `go-git` to v5.17.2 (go-gitea#37060) Replace Monaco with CodeMirror (go-gitea#36764) Update Combine method to treat warnings as failures and adjust tests (go-gitea#37048) Raise minimum Node.js version to 22.18.0 (go-gitea#37058) Update golangci-lint to v2.11.4 (go-gitea#37059) Upgrade `golang.org/x/image` to v0.38.0 (go-gitea#37054) Increase e2e test timeouts on CI to fix flaky tests (go-gitea#37053) Refactor "org teams" page and help new users to "add member" to an org (go-gitea#37051) Refactor issue sidebar and fix various problems (go-gitea#37045) Add tests for pull request's content_version in API (go-gitea#37044) Enable concurrent vitest execution (go-gitea#36998) Fix theme discovery and Vite dev server in dev mode (go-gitea#37033) ... # Conflicts: # templates/user/dashboard/feeds.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
sequence.concurrentto run all js tests in parallel. This will help catch potential concurrency bugs in the future. The "Repository Branch Settings" test was not concurrency-safe, it was refactored to remove shared mutable state.Co-Authored-By: Claude (claude-opus-4-6) noreply@anthropic.com